Remove random package Random prefixes.#333
Closed
terrorbyte wants to merge 1 commit intomainfrom
Closed
Conversation
Having every function prefixed with Random is redundant and can sometimes cause more confusion than it helps. This is a pretty big change and should not be merged until supported packages can change.
terrorbyte
added
documentation
Contributor
|
This would break the API. Unless you are proposing a major version bump, which I'd be hard pressed to agree with, this is sort of DOA. While I agree that the naming scheme is imperfect, it's certainly not worthy of breaking others integrations nor introducing a major version update. |
Collaborator
Author
|
Fair and reasonable. I considered deprecating the old functions but leaving them to keep stability. I'll make a issue and maybe add a "api-break" change comment leading here. |
terrorbyte
added
the
api-break
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having every function prefixed with Random is redundant and can sometimes cause more confusion than it helps. This is a pretty big change and should not be merged until supported packages can change.